fix(api): image downloads with correct filename #6735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
brandonrising and
hipsterusername
as code owners
hipsterusername
approved these changes
Aug 10, 2024
hipsterusername
force-pushed
the
psyche/fix/api/image-dl-name
branch
from
56969b0
to
2aa20bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6607 we fixed a race condition with deleting images. The fix inadvertently removed some headers from the image serving route that caused #6730. Headers restored
Related Issues / Discussions
Closes #6730
QA Instructions
Open image in new tab -> save image -> should use the correct filename
Merge Plan
n/a
Checklist