Build container image on-demand #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebr
requested review from
lstein,
blessedcoolant and
hipsterusername
as code owners
ebr
changed the title
ebr
changed the title
brandonrising
approved these changes
Sep 3, 2024
hipsterusername
approved these changes
Sep 3, 2024
ebr
force-pushed
the
ebr/build-on-demand
branch
from
7110e77
to
5dfd4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the container build GitHub Actions workflow to include an option that allows pushing the built image to the container registry from any branch (in addition to
main), but only when triggered manually using Workflow Dispatch.This feature enables the creation of ad-hoc images from any branch to test changes in a containerized environment, eliminating the need to build and push images locally.
Additionally, it supports forked repositories, where the image will be pushed to the package registry owned by the fork's owner.
The PR also bumps Github Action version pins in the workflow in response to deprecation warnings.
Merge Plan
Merge when approved
Checklist