-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brandon/cast unquantized flux to bfloat16 #6815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonrising
requested review from
lstein,
blessedcoolant,
RyanJDick and
hipsterusername
as code owners
September 5, 2024 17:09
github-actions
bot
added
python
PRs that change python files
backend
PRs that change backend files
labels
Sep 5, 2024
hipsterusername
approved these changes
Sep 5, 2024
RyanJDick
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a handful of comments - mostly around all of the explicit memory management we are doing with (del
and gc.collect()
).
I tested it as-is and it works for me. The quality seems pretty clearly worse than a 4-bit quantized model though 😅
RyanJDick
approved these changes
Sep 5, 2024
…mory during upcasting
brandonrising
force-pushed
the
brandon/cast-unquantized-flux-to-bfloat16
branch
from
September 5, 2024 19:38
117e3e0
to
f08e942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR forces unquantized flux model state dicts to be converted to bfloat16 since that's all we support for inference currently. This can be removed or minimized as we support more data types in the future. This will allow us to support the seemingly common float8 flux fine tunes available on sites like huggingface and civitAI.
QA Instructions
Attempt to perform inference with a model similar to this one
Merge Plan
Can be merged when tested and approved
Checklist