feat, fix: canvas v2 followups 1 #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
- Each entity gets its own `CanvasEntityFilterer` - Add auto-preview feature to filter, debounced by 1000ms leading + trailing - Fix flash when preview updates
Hopefully this resolves the issue w/ alt as a quick switch for color picker on windows.
- Add selectors to get the default control adapter and ip adapter with model, preferring controlnet over t2i adapter for model - Add hooks to add each entity type, using the defaults - Add hooks to add prompts/ip adapters to a regional guidance layer - Use the defaults in other places where we add control layers or ip adapters (e.g. dnd-triggered entity creation)
This API is not available in all browsers. Also add an eslint rule to prevent usage in the future.
There's a race condition where we sometimes get progress events from canceled queue items, depending on the timing of the cancellation request and last event or two from the queue item. I can't imagine how to resolve this except by tracking all cancellations and ignoring events for cancelled items, which is implemented in this change.
psychedelicious
changed the title
psychedelicious
changed the title
hipsterusername
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Misc canvas v2 followups - see commits for details.
Related Issues / Discussions
Some feedback from offline discussions/discord
QA Instructions
Try the things in the list of commits.
Merge Plan
n/a
Checklist