Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix,feat: canvas followups 9 #6860

Merged
merged 19 commits into from
Sep 16, 2024
Merged

fix,feat: canvas followups 9 #6860

merged 19 commits into from
Sep 16, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Fix: Right click opens image in new tab
  • Fix: "Pull Bbox Into..." translations
  • Fix: Gallery sometimes not filling up with images
  • Feat: Rename "IP Adapter" -> "Reference Image"
  • Feat: Close Viewer button in Viewer is an Icon
  • Feat: Split up various menus into Global/Regional/Layers
  • Feat: Tighten up IP Adapter settings layout
  • Feat: Gallery image hover button to open in viewer
  • Feat: Drop overlay styles (easier to which drop area is active)
  • Feat: Add ref image drop areas to canvas
  • Internal: Rename regions state to regionalGuidance
  • Internal: Tidy up a lot of utilities for canvas state mgmt

Related Issues / Discussions

Discord & offline discussion

QA Instructions

Try the things out

Merge Plan

Will do an alpha after

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@psychedelicious
fix(ui): right click opens image in new tab
8c50ef1
@psychedelicious
feat(ui): add sections to add layer menu
886d5c9
@psychedelicious
feat(ui): ip adapter -> reference image (internal state)
911294b 
We are renaming "IP Adapter" to "Reference Image".

- Update all internal state
- Update all components
@psychedelicious
tidy(ui): create/move store utils to separate file
5a21e58
@psychedelicious
feat(ui): updated canvas context menu
24ed17e
@psychedelicious
feat(ui): update translations for reference image
1ced3f4
@psychedelicious
feat(ui): more translation updates
1e9b0ee 
- Migrate some translations to `controlLayers` namespace
- Remove the `controlnet` namespace entirely
- Remove other unused translations
@psychedelicious
feat(ui): close viewer button is an icon
c33beda 
Reduces the awkwardness of having two identical buttons visible at once.
@psychedelicious
tidy(ui): clean up addLayerHooks
b7137b7
@psychedelicious
fix(ui): pull bbox into ref image translations
8cfbbc6
@psychedelicious
feat(ui): updated add entity buttons/menu
2c0b4fb
@psychedelicious
feat(ui): tighten up ip adapter settings layout
0eb7f91
@psychedelicious
feat(ui): revised regional guidance
ddd0864
@psychedelicious
tidy(ui): rename canvas state "regions" -> "regionalGuidance"
e6b0ace
@psychedelicious
fix(ui): gallery not filling up
b97599a 
Floating point precision issue.
@psychedelicious
feat(ui): tweak perserve mask translation
476070e
@psychedelicious
feat(ui): gallery image hover button to open in viewer
02873ca
@psychedelicious
feat(ui): tweak drop overlay styles
1e0c0a7
@psychedelicious
feat(ui): add ref image drop targets to canvas
5e92ef4
@github-actions github-actions bot added the frontend PRs that change frontend files label Sep 16, 2024
@hipsterusername hipsterusername merged commit 7fe1135 into main Sep 16, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/canvas-followups-9 branch September 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername