Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): restore Settings Modal functionality to render using children #6864

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(ui): restore Settings Modal functionality to render using children #6864

merged 2 commits into from
Sep 17, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Sep 16, 2024 •
edited
Loading

Summary

Restores functionality where Settings Modal is rendered using children that trigger it

Related Issues / Discussions

QA Instructions

Tested settings modal in OSS and commercial ✅

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Sep 16, 2024
@maryhipp maryhipp enabled auto-merge (rebase) September 17, 2024 00:07
@maryhipp maryhipp merged commit 783441a into main Sep 17, 2024
14 checks passed
@maryhipp maryhipp deleted the maryhipp/restore-settings-children branch September 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @psychedelicious