fix(ui): canvas followups 10 #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
maryhipp
approved these changes
Sep 17, 2024
Make em all strings to prevent nesting `<p>` elements. Slightly changes appearance - font size is a bit smaller.
psychedelicious
force-pushed
the
psyche/canvas-followups-10
branch
from
b7d24fb
to
62b5317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes:
shift+cwhile in the middle of drawing on a layer, there's a bit of a janky delay as the reset propagates from redux and to the canvas classes. The hotkey now cancels the in-progress drawing, indirectly fixing the jank.Related Issues / Discussions
Shift+c issue reported on discord.
QA Instructions
n/a
Merge Plan
n/a
Checklist