feat(ui): canvas error handling #6896
Merged
Commits on Sep 20, 2024
-
feat(ui): revised
getImageDTOutils- Rename util to `getImageDTOSafe` - Update API to accept the same options as RTKQ's `initiate` - Add `getImageDTO`; while `getImageDTOSafe` returns null if the image is not found, the new util throws - Update usage of `getImageDTOSafe`
-
-
-
feat(ui): reworked filter execution & error handling
Two main changes: - Add `runGraphAndReturnImageOutput` to `CanvasStateApiModule`. This method is a safe and convenient abstraction to execute a graph and retrieve the image output of one of its nodes. It supports cancellation (via an AbortSignal) and timeout. - Update filters to build whole graphs, as opposed to nodes. These changes allow: - Filter execution is resilient, with all error cases handled (afaik) - `CanvasEntityFilterer` class is much simpler - Stuck or long-running filters may be canceled - Filters may be arbitrarily complex - so long as there is one node that outputs an image, the filter will just work
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.