Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodes): return copies of objects in invocation ctx #7195

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

fix(nodes): return copies of objects in invocation ctx

Related Issues / Discussions

QA Instructions

Suppose we could do some perf testing, but I don't think it really matters, as we need to make this change regardless.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files services PRs that change app services labels Oct 25, 2024
@hipsterusername hipsterusername force-pushed the psyche/fix/nodes/return-copies-in-ctx branch from fd53f38 to 25ef108 Compare October 25, 2024 12:12
@hipsterusername hipsterusername merged commit ddd5b10 into main Oct 25, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/fix/nodes/return-copies-in-ctx branch October 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python PRs that change python files services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: context.tensors.load returns an object that is modifiable in-place
2 participants