Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui,api): support for HF tokens in UI, handle Unauthorized and Forbidden responses from HF #7201

Merged
merged 3 commits into from
Oct 31, 2024
Merged

feat(ui,api): support for HF tokens in UI, handle Unauthorized and Forbidden responses from HF #7201

merged 3 commits into from
Oct 31, 2024

Conversation

maryhipp
Copy link
Collaborator

Summary

  • restores some old UI for supporting HF token functionality in the model manager UI
  • if user attempts to download a HF model that requires a token but has either a missing or invalid one (Unauthorized error), they will be prompted to add a valid token in UI
  • if user attempts to download a HF model that requires acceptance of terms such as SD3.5 (Forbidden error), they will be prompted to visit the repo on huggingface.com and take action to get access to that model (such as accepting the terms)

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added api python PRs that change python files frontend PRs that change frontend files labels Oct 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@psychedelicious psychedelicious enabled auto-merge (rebase) October 31, 2024 04:37
@psychedelicious psychedelicious merged commit d3a82f7 into main Oct 31, 2024
14 checks passed
@psychedelicious psychedelicious deleted the maryhipp/hf-token branch October 31, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

Assignees
No one assigned
Labels
api frontend PRs that change frontend files python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @psychedelicious