-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add Support for rocm57 required by some AMD GPU #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cbayle
wants to merge
8
commits into
invoke-ai:main
Choose a base branch
from
cbayle:rocm57
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
edd2426
Remove extra \n that make script fails
cbayle b3564c6
Add groups and user membership for /dev/kfd and /dev/dri/card0 when r…
cbayle 2afcb15
Add support for rocm5.7 required by some AMD GPUs
cbayle dee662f
fix if exists test on device
cbayle 78345ee
revert unwanted change on rocm version for rocm profile
cbayle 9620c5d
Merge branch 'invoke-ai:main' into rocm57
cbayle 5af90a7
Merge branch 'invoke-ai:main' into rocm57
cbayle d5b65bf
Merge branch 'main' into rocm57
cbayle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,25 @@ USER=ubuntu | |
# if the user does not exist, create it. It is expected to be present on ubuntu >=24.x | ||
_=$(id ${USER} 2>&1) || useradd -u ${USER_ID} ${USER} | ||
# ensure the UID is correct | ||
usermod -u ${USER_ID} ${USER} 1>/dev/null | ||
usermod -u ${USER_ID} ${USER} || true 1>/dev/null | ||
mkdir -p /home/${USER} | ||
chown ${USER} /home/${USER} | ||
|
||
# Add ${USER} in render group when required | ||
if [ -c /dev/kfd ] | ||
then | ||
RENDER_GID=$(stat -c %g /dev/kfd) | ||
_=$(getent group ${RENDER_GID} 2>&1) || groupadd -g ${RENDER_GID} render | ||
usermod -a -G $RENDER_GID $USER | ||
fi | ||
|
||
# Add ${USER} in video group when required | ||
if [ -c /dev/dri/card0 ] | ||
then | ||
VIDEO_GID=$(stat -c %g /dev/dri/card0) | ||
_=$(getent group ${VIDEO_GID} 2>&1) || groupadd ${VIDEO_GID} video | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should be |
||
usermod -a -G $VIDEO_GID $USER | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. although this will likely work as is, it is more correct to do |
||
fi | ||
|
||
### Set the $PUBLIC_KEY env var to enable SSH access. | ||
# We do not install openssh-server in the image by default to avoid bloat. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.