Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRA training of non-attention UNet layers #11

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

RyanJDick
Copy link
Collaborator

@RyanJDick RyanJDick commented Aug 8, 2023

Add ability to inject LoRA layers into the non-attention blocks of the UNet (specifically the ResnetBlock2D, Downsample2D, and Upsample2D). This matches the kohya_ss behaviour when conv_dim is set.

Manual Testing:
I trained with this feature for a few epochs and confirmed that the resultant model was sane and can be loaded in InvokeAI. I intend to do more extensive experimentation in the future to better understand the impact of this feature.

  • Merge previous PRs and change target branch to main

@RyanJDick RyanJDick marked this pull request as ready for review August 8, 2023 18:58
Copy link
Collaborator

@brandonrising brandonrising left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from ryan/datasets to main August 10, 2023 20:45
@RyanJDick RyanJDick merged commit 04a5dc0 into main Aug 10, 2023
1 check passed
@RyanJDick RyanJDick deleted the ryan/more-unet-lora-layers branch August 10, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants