Preparation for SDXL support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck to training script.
|
|
||
| # This logic was copied from | ||
| # https://github.com/invoke-ai/InvokeAI/blob/e77400ab62d24acbdf2f48a7427705e7b8b97e4a/invokeai/backend/model_management/model_probe.py#L412-L421 | ||
| # This seems fragile. If you see this and know of a better way to detect the base model version, your contribution |
There was a problem hiding this comment.
This seems to be the standard way of doing it right now unfortunately. To specifically point out xl vs not xl, the diffusers class name is pretty clear in the root config of the model. Beyond that, I'm not sure of a better way.
brandonrising
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles a few related changes:
Refactoring to prepare for SDXL support in a future PR. Specifically, split training utility functions that can be re-used by SDXL out into a new file.
Added utility functions to check diffusers model versions (V1, V2, SDXL) for the purpose of providing more informative error messages if an unsupported base model is selected.
Merge previous PRs and change target branch to main