Skip to content

Conversation

@alvarolivie
Copy link
Contributor

@alvarolivie alvarolivie commented May 20, 2025

  • Add a BE PEPPOL example

Pre-Review Checklist

  • I've read the CONTRIBUTING.md guide.
  • N/A I have performed a self-review of my code.
  • N/A I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents to show my changes in use, if appropriate.
  • N/A When adding or modifying a tax regime or addon, I've added links to the source of the changes, either structured or in the comments.
  • I've run go generate . to ensure that the Schemas and Regime data are up to date.
  • N/A All linter warnings have been reviewed and fixed.
  • N/A I've been obsessive with pointer nil checks to avoid panics.
  • N/A The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (9593fec) to head (cea871f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files         286      286           
  Lines       15862    15862           
=======================================
  Hits        14312    14312           
  Misses       1231     1231           
  Partials      319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alvarolivie alvarolivie requested a review from samlown May 20, 2025 14:08
@alvarolivie alvarolivie marked this pull request as ready for review May 20, 2025 14:08
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Supplier and Customer do not have a participant ID (inboxes), so as an example for Peppol, it probably needs a bit more work...

@samlown samlown added the needs changes The PR/Issue is put on hold as it needs further changes before it can be merged. label Jul 7, 2025
@alvarolivie alvarolivie requested a review from samlown October 8, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changes The PR/Issue is put on hold as it needs further changes before it can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants