Skip to content

Conversation

@alvarolivie
Copy link
Contributor

@alvarolivie alvarolivie commented Oct 24, 2025

  • Added a missing Tax def

Pre-Review Checklist

  • I've read the CONTRIBUTING.md guide.
  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents to show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes, either structured or in the comments.
  • I've run go generate . to ensure that the Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (ebdf3dc) to head (35456ba).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         297      297           
  Lines       14555    14555           
=======================================
  Hits        13416    13416           
  Misses        819      819           
  Partials      320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing INC (Impuesto Nacional al Consumo / National Consumption Tax) tax category definition for the Colombian tax regime.

  • Added comprehensive tax category definition for INC with English and Spanish translations
  • Updated the tax category constant to include a descriptive comment
  • Generated corresponding JSON schema data for the new tax category

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
regimes/co/tax_categories.go Added INC tax category definition with localized names and titles, plus comment to the constant
data/regimes/co.json Generated JSON schema output for the new INC tax category

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alvarolivie alvarolivie marked this pull request as ready for review October 24, 2025 13:08
@alvarolivie alvarolivie requested a review from samlown October 24, 2025 13:08
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a better reference to the source of this tax category or a bit more comments around why this differs from the regular IC (Impuesto Consumo).

@samlown samlown merged commit 529bd41 into main Oct 28, 2025
8 checks passed
@samlown samlown deleted the inc-colombia branch October 28, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants