-
Couldn't load subscription status.
- Fork 22
INC tax in Colombia #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INC tax in Colombia #629
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 297 297
Lines 14555 14555
=======================================
Hits 13416 13416
Misses 819 819
Partials 320 320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the missing INC (Impuesto Nacional al Consumo / National Consumption Tax) tax category definition for the Colombian tax regime.
- Added comprehensive tax category definition for INC with English and Spanish translations
- Updated the tax category constant to include a descriptive comment
- Generated corresponding JSON schema data for the new tax category
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| regimes/co/tax_categories.go | Added INC tax category definition with localized names and titles, plus comment to the constant |
| data/regimes/co.json | Generated JSON schema output for the new INC tax category |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a better reference to the source of this tax category or a bit more comments around why this differs from the regular IC (Impuesto Consumo).
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.