Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news also to the notification system #2135

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

foxriver76
Copy link
Collaborator

No description provided.

@foxriver76 foxriver76 marked this pull request as draft September 28, 2023 06:46
}
let showIt = true;

if (showIt && message['date-start'] && new Date(message['date-start']).getTime() > today) {

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'showIt' always evaluates to true.
@foxriver76 foxriver76 marked this pull request as ready for review October 9, 2023 06:54
@foxriver76 foxriver76 merged commit 2537f32 into master Oct 10, 2023
15 checks passed
@foxriver76 foxriver76 deleted the news-to-notification-system branch October 10, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant