Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make valvePosition writable #750

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

jlegen
Copy link
Contributor

@jlegen jlegen commented Jan 10, 2023

setting valvePosition automatically sets automaticValveControl to false

setting valvePosition automatically sets automaticValveControl to false
@klein0r
Copy link
Contributor

klein0r commented Jan 11, 2023

Please add the coap cmd, too: https://github.com/iobroker-community-adapters/ioBroker.shelly/actions/runs/3887247004/jobs/6633289985

      Missing (or invalid) coap cmd definition for shellytrv (tmp.valvePosition)

@klein0r
Copy link
Contributor

klein0r commented Jan 11, 2023

Why have you dropped the coap_publish??

@jlegen
Copy link
Contributor Author

jlegen commented Jan 11, 2023

sorry for that, i am still on version 6.2.x - there's no COAP for shelly-trv; and since COAP was not supported at the beginning with shelly-trv, i switched my shelly-instance to mqtt, and totally forgot about COAP...
Reason for using 6.2.x - i currently cannot yet run admin v6.x...

@klein0r
Copy link
Contributor

klein0r commented Jan 11, 2023

Please restore coap_publish and drop http_publish / http_publish_funct in the coap section

@jlegen
Copy link
Contributor Author

jlegen commented Jan 12, 2023

sorry, looks like i need a bit more time for this - i can't get COAP to work with my shellytrvs at all (other shellys are fine), so i cannot yet test the coap stuff.
But i also realized that this PR is somewhat incomplete anyways - did not notice that target_t.enabled (automatic valve control) is not yet exposed upstream, so this needs to go into this PR as well. Not sure if we should leave this open, or just discard it...

@klein0r
Copy link
Contributor

klein0r commented Jan 12, 2023

Your decision

@GermanBluefox
Copy link
Member

@klein0r Could you give a look on this PR?

@klein0r klein0r merged commit a5c4c73 into iobroker-community-adapters:master Sep 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants