fix: properly configure the single 1024x1024 iOS icon #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
IT-MikeS,
markemer,
theproducer,
ItsChaceD and
giralte-ionic
IT-MikeS
approved these changes
Oct 2, 2023
markemer
approved these changes
Oct 2, 2023
jcesarmobile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the single icon generation to generate a single 1024x1024 icon and configure it as a single universal icon instead of configuring it as a marketing icon, which was causing a duplicate 1024x1024 entry, one for the universal and another for the marketing.
Also made it regenerate the whole
Contents.jsonas current code was keeping existing values, so it wasn't configuring a single icon, and also remove old files that could be there from previous v2 executions.Removed the spotlight, notification and settings icon generation code/tests as I don't think it was having any effect anymore since there is a single icon now.
closes #558