feat: update to show installation requirements #47
Conversation
There was a problem hiding this comment.
The original file is the one inside plugin folder, then it gets copied into the root if running npm run build.
https://github.com/ionic-team/capacitor-google-maps/blob/main/plugin/README.md
The deployment target should also be changed in the project, not just in the Podfile, the text might look like this
https://capacitorjs.com/docs/v5/updating/4-0#raise-ios-deployment-target
There was a problem hiding this comment.
It's still not clear, you have to edit the deployment target for both the project and any targets your project has.
The text on the upgrade guide says
Do the following for your Xcode project: select the Project within the project editor and open the Build Settings tab. Under the Deployment section, change iOS Deployment Target to iOS 13.0. Repeat the same steps for any app Targets.
So should be something like that but with 14 instead of 13
|
It says:
|
|
Yeah, that's incomplete or unclear, you have to change it for both the project and all the targets, each one of them have a 
|
|
I've cleaned up the wording to specify that you need to do it for the target app. The projects deployment target doesnt need to be updated (see this sample app) |
There was a problem hiding this comment.
Despite the app might build with different deployment targets on the project and the targets, it can cause issues, so it's better to always have the versions in sync.
The new text is incorrect, it should say in the opposite order, like
select
Targets>App(or the name of your target) and in theBuild Settingstab
Users could have more than a target, so that's why I'm asking to use the same text we have on the migrate guide, and also for consistency
|
Ok, changed again. |
This adds the missing requirements for minimum iOS deployment target of 14.0 and the skipLibCheck property in TSConfig.