feat(google-maps): Separate mapId for Google Maps Cloud IDs #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
markemer,
jcesarmobile,
ItsChaceD,
IT-MikeS and
giralte-ionic
IT-MikeS
approved these changes
Aug 23, 2023
ItsChaceD
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
It looks good, but should we use different config options for Android and iOS?
the mapId is unique per platform, so having a single mapId option will mean users will have to detect the platform and pass the id for the specific platform, a single mapId can't be used, it will error if you try to use a javascript map id in Android (on iOS it surprisingly works, but it shouldn't according to the docs)
|
I agree with Julio that the platform should be part of the params passed here to avoid the problem. I also don't believe we should assume that iOS will always accept a javascript platform id. |
giralte-ionic
approved these changes
Sep 7, 2023
Comment on lines
97
to
98
| MapsInitializer.Renderer.LATEST -> Log.d("Capacitor Google Maps", "Latest Google Maps renderer enabled") | ||
| MapsInitializer.Renderer.LEGACY -> Log.d("Capacitor Google Maps", "Legacy Google Maps renderer enabled - Cloud based map styling and advanced drawing not available") |
There was a problem hiding this comment.
Use Logger.debug instead of android Log class so it can be globally disabled
jcesarmobile
approved these changes
Oct 23, 2023
jcesarmobile
pushed a commit
that referenced
this pull request
Dec 4, 2023
LaravelFreelancerNL
pushed a commit
to dennis-wedevise/capacitor-plugins
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a separate optional
mapIdthat is used for cloud based map styling and features:https://developers.google.com/maps/documentation/get-map-id
closes: #1708
closes ionic-team/capacitor#7011