fix(share): Address Android 14 changes #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
IT-MikeS
approved these changes
Oct 20, 2023
|
Released dev build of share with dev version: 5.0.7-dev-1849-20231101T165859.0 |
IT-MikeS
approved these changes
Nov 1, 2023
ItsChaceD
approved these changes
Nov 1, 2023
|
Sorry to comment on a closed PR, but can we please get this released in version 5.0.7? |
|
No, it’s a breaking change, targeting SDK 34 will only be supported in capacitor 6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simpler solution I've found for addressing Android 14 changes.
I think
FLAG_ALLOW_UNSAFE_IMPLICIT_INTENTis safe to use because we only use the pending intent for getting the package of the app the user selected to share, we null the value right before the share starts so if somebody managed to get ourBroadcastReceivedit will have no effect.But if somebody thinks this is unsafe I can try some different approach that doesn't use
FLAG_ALLOW_UNSAFE_IMPLICIT_INTENT.