feat(filesystem): add removeAllListeners method
#1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Can you rebase or cherry-pick this commit into 5.x branch?
In Capacitor 6 it won't be necessary to do this and we will remove those methods, but would be good to fix it for Capacitor 5 version.
Actually, it should be two separate PRs as the type changes are still needed for Capacitor 6, can you remove the .m changes in this PR and send a separate one to 5.x branch with both changes. Also the return type should be CAPPluginReturnPromise, not CAPPluginReturnNone
|
Done. I created a new PR: #1868 |
jcesarmobile
approved these changes
Oct 31, 2023
LaravelFreelancerNL
pushed a commit
to dennis-wedevise/capacitor-plugins
that referenced
this pull request
Dec 19, 2023
Co-authored-by: jcesarmobile <[email protected]>
NetEvolutions
added a commit
to werktools/capacitor-plugins
that referenced
this pull request
Jan 30, 2024
…ols/capacitor-plugins into ios-location-aware-camera * 'ios-location-aware-camera' of https://github.com/werktools/capacitor-plugins: (24 commits) fix(keyboard): distribute the new SPM files (ionic-team#1895) chore: only lint plugins that changed (ionic-team#1880) feat(google-maps)!: Update iOS dependencies (ionic-team#1890) chore: update Podfile paths (ionic-team#1891) chore(ios): fix verify script (ionic-team#1892) chore(release): publish [skip ci] docs(README): Update note for Capacitor 6 (ionic-team#1883) chore: update dependencies to use next tag (ionic-team#1889) chore: bump version to 6.0.0-alpha.0 (ionic-team#1888) feat(app,haptics,status-bar,keyboard): Supporting Swift Package Manager (ionic-team#1886) chore(android): upgrade gradle wrapper and plugin to 8.2.x (ionic-team#1885) refactor(ios): remove removeAllListeners methods (ionic-team#1867) feat(camera)!: Use Android Photo Picker instead of ACTION_PICK intent (ionic-team#1833) fix(share): Address Android 14 changes (ionic-team#1849) chore: Remove lerna bootstrap form scripts (ionic-team#1875) chore: fix toggle-local npm script (ionic-team#1847) feat(filesystem): add removeAllListeners method (ionic-team#1862) docs(google-maps/geolocation)!: Removing deprecated usage descriptions for iOS (ionic-team#1855) chore: use the new addListener return type (ionic-team#1846) chore: ci release dev for non-draft PR's (ionic-team#1854) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing method
removeAllListeners.