fix(ios): Picking ProRAW pictures from Gallery #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If object can't be loaded, load its data representation. Considering that the code was duplicated for multiple and single selections, refactor the code to remove redundancy. For multiple selection, since it's not possible to cancel image loading when one fails, the refactor also changes concurrent loading to serial. References: https://outsystemsrd.atlassian.net/browse/RMET-3243
OS-ricardomoreirasilva
force-pushed
the
fix/RMET-3243/pick-proraw-photos
branch
from
d2b524e to
1eb5e46
Compare
OS-ricardomoreirasilva
requested review from
ItsChaceD,
dallastjames,
IT-MikeS,
alexgerardojacinto and
OS-martacarlos
OS-ricardomoreirasilva
changed the title
OS-ricardomoreirasilva
changed the title
OS-ricardomoreirasilva
changed the title
alexgerardojacinto
approved these changes
May 9, 2024
OS-martacarlos
approved these changes
May 9, 2024
OS-ricardomoreirasilva
added a commit
that referenced
this pull request
May 9, 2024
OS-ricardomoreirasilva
added a commit
that referenced
this pull request
May 9, 2024
NetEvolutions
added a commit
to werktools/capacitor-plugins
that referenced
this pull request
May 27, 2024
…tion-aware-camera-5.x * commit 'c4feee0846830308a38154b9c1538031b374e2b8': fix(ios): apply filter to fetch correct scene object (ionic-team#2103) fix(ios): Picking ProRAW pictures from Gallery (ionic-team#2098) (ionic-team#2099) fix(android): removes setOnExitAnimationListener when fade out is disabled fix(ios): iOS panorama photos selected through CameraPlugin are corrupted (ionic-team#2088) bug(@capacitor/screen-orientation): iOS landscape lock using incorrect mappings (ionic-team#2049) chore: Update install instructions with latest-5 tag (ionic-team#2084) chore: publish as latest-5 (ionic-team#2081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the image object can't be loaded, load its data representation.
Considering that the code was duplicated for multiple and single selections, refactor the code to remove redundancy.
For multiple selection, since it's impossible to cancel image loading when one fails, the refactor also changes concurrent loading to serial.
References: https://outsystemsrd.atlassian.net/browse/RMET-3243