fix(browser): call notifyListeners only when browser is dismissed #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a bug on iOS that was detected when trying to lock the device's orientation after the safari view controller was dismissed by the user this happened because the view controller wasn't being properly closed/dismissed and the listeners were being incorrectly notified https://outsystemsrd.atlassian.net/browse/RMET-3453
|
Released dev build of browser with dev version: 7.0.0-dev-2186-20240909T134639.0 |
alexgerardojacinto
approved these changes
Sep 2, 2024
IT-MikeS
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug on @capacitor/browser on iOS: when trying to lock the device's orientation after the safari view controller was dismissed/closed by the user , an error occured:
None of the requested orientations are supported by the view controller. Requested: portrait; Supported: landscapeLeftThis seemed to be happening because the view controller wasn't being properly closed/dismissed and the listeners were being incorrectly notified.
initial bug @ here
reference: https://outsystemsrd.atlassian.net/browse/RMET-3453