feat(modal): add expandToScroll property to allow scrolling at all breakpoints #15266
Annotations
10 errors and 1 notice
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L1
1) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:55:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the header
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L1
1) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:55:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the header
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L1
1) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:55:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the header
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L1
2) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:59:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the content
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L1
2) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:59:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the content
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L1
2) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:59:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the content
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L94
3) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:89:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › content should be scrollable after gesture ends
Error: Timed out 5000ms waiting for expect(locator).toHaveJSProperty(expected)
Locator: locator('ion-modal ion-content')
Expected: true
Received: false
Call log:
- expect.toHaveJSProperty with timeout 5000ms
- waiting for locator('ion-modal ion-content')
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
92 |
93 | const content = page.locator('ion-modal ion-content');
> 94 | await expect(content).toHaveJSProperty('scrollY', true);
| ^
95 | });
96 | });
97 | });
at /ionic/src/components/modal/test/card/modal-card.e2e.ts:94:31
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L94
3) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:89:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › content should be scrollable after gesture ends
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveJSProperty(expected)
Locator: locator('ion-modal ion-content')
Expected: true
Received: false
Call log:
- expect.toHaveJSProperty with timeout 5000ms
- waiting for locator('ion-modal ion-content')
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
92 |
93 | const content = page.locator('ion-modal ion-content');
> 94 | await expect(content).toHaveJSProperty('scrollY', true);
| ^
95 | });
96 | });
97 | });
at /ionic/src/components/modal/test/card/modal-card.e2e.ts:94:31
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-card.e2e.ts#L94
3) [Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:89:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › content should be scrollable after gesture ends
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveJSProperty(expected)
Locator: locator('ion-modal ion-content')
Expected: true
Received: false
Call log:
- expect.toHaveJSProperty with timeout 5000ms
- waiting for locator('ion-modal ion-content')
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
- locator resolved to <ion-content class="ion-padding ios content-ltr hydrated">…</ion-content>
- unexpected value "false"
92 |
93 | const content = page.locator('ion-modal ion-content');
> 94 | await expect(content).toHaveJSProperty('scrollY', true);
| ^
95 | });
96 | });
97 | });
at /ionic/src/components/modal/test/card/modal-card.e2e.ts:94:31
|
Run /./.github/workflows/actions/test-core-screenshot:
src/components/modal/test/card/modal-tablet.e2e.ts#L1
4) [Mobile Chrome] › src/components/modal/test/card/modal-tablet.e2e.ts:53:11 › card modal: functionality - ios/ltr › card modal: swipe to close - tablet - ios/ltr › it should swipe to close when swiped on the header
Test timeout of 30000ms exceeded.
|
Run /./.github/workflows/actions/test-core-screenshot
10 failed
[Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:55:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the header
[Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:59:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › it should swipe to close when swiped on the content
[Mobile Chrome] › src/components/modal/test/card/modal-card.e2e.ts:89:11 › card modal: functionality - ios/ltr › card modal: swipe to close - ios/ltr › content should be scrollable after gesture ends
[Mobile Chrome] › src/components/modal/test/card/modal-tablet.e2e.ts:53:11 › card modal: functionality - ios/ltr › card modal: swipe to close - tablet - ios/ltr › it should swipe to close when swiped on the header
[Mobile Chrome] › src/components/modal/test/card/modal-tablet.e2e.ts:57:11 › card modal: functionality - ios/ltr › card modal: swipe to close - tablet - ios/ltr › it should swipe to close when swiped on the content
[Mobile Chrome] › src/components/modal/test/card/modal-tablet.e2e.ts:87:11 › card modal: functionality - ios/ltr › card modal: swipe to close - tablet - ios/ltr › content should be scrollable after gesture ends
[Mobile Chrome] › src/components/modal/test/card-scroll-target/modal.e2e.ts:10:11 › card modal - scroll target - ios/ltr › card modal: swipe to close › it should swipe to close when swiped on the content
[Mobile Chrome] › src/components/modal/test/card-scroll-target/modal.e2e.ts:39:11 › card modal - scroll target - ios/ltr › card modal: swipe to close › content should be scrollable after gesture ends
[Mobile Chrome] › src/components/modal/test/sheet/modal.e2e.ts:6:9 › sheet modal: rendering - ios/ltr › should not have visual regressions
[Mobile Chrome] › src/components/modal/test/sheet/modal.e2e.ts:6:9 › sheet modal: rendering - md/ltr › should not have visual regressions
428 passed (12.4m)
|
Loading