Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): do not float label because of slotted items #29948

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −5
Open

fix(input): do not float label because of slotted items #29948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c54cf7
Fix #28665: do not float label because of slotted items
ErikOnBike Oct 18, 2024
d31bfa3
Use 'visibility: hidden' to keep size consistent
ErikOnBike Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/components/input/input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,13 @@
max-width: calc(100% / #{$form-control-label-stacked-scale});
}

/**
* This removes the slotted items on floating label when empty and no focus.
*/
:host(.input-label-placement-floating:not(.has-focus):not(.has-value)) .native-wrapper > [slot] {
visibility: hidden;
}

// Start/End Slots
// ----------------------------------------------------------------

Expand Down
7 changes: 2 additions & 5 deletions core/src/components/input/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ export class Input implements ComponentInterface {
}

render() {
const { disabled, fill, readonly, shape, inputId, labelPlacement, el, hasFocus, clearInputIcon } = this;
const { disabled, fill, readonly, shape, inputId, labelPlacement, hasFocus, clearInputIcon } = this;
const mode = getIonMode(this);
const value = this.getValue();
const inItem = hostContext('ion-item', this.el);
Expand All @@ -698,7 +698,6 @@ export class Input implements ComponentInterface {
const clearIconData = clearInputIcon ?? defaultClearIcon;

const hasValue = this.hasValue();
const hasStartEndSlots = el.querySelector('[slot="start"], [slot="end"]') !== null;

/**
* If the label is stacked, it should always sit above the input.
Expand All @@ -714,11 +713,9 @@ export class Input implements ComponentInterface {
* other when the label isn't floating above the input. This doesn't
* apply to the outline fill, but this was not accounted for to keep
* things consistent.
*
* TODO(FW-5592): Remove hasStartEndSlots condition
*/
const labelShouldFloat =
labelPlacement === 'stacked' || (labelPlacement === 'floating' && (hasValue || hasFocus || hasStartEndSlots));
labelPlacement === 'stacked' || (labelPlacement === 'floating' && (hasValue || hasFocus));

return (
<Host
Expand Down