Skip to content

fix(toolbar): allow slot to size to content to account for images #30508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 26, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jun 23, 2025

Issue number: internal


What is the current behavior?

Images do not appear because their width is calculated as 0 when determining the widths of slotted content.

What is the new behavior?

Sets the flex-basis variable to auto if the slot contains an img to allow it to calculate the width using the image's intrinsic width.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.6.2-dev.11750780384.13227a56

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 4:08pm

@github-actions github-actions bot added the package: core @ionic/core package label Jun 23, 2025
@brandyscarney brandyscarney marked this pull request as ready for review June 23, 2025 21:55
@brandyscarney brandyscarney requested a review from a team as a code owner June 23, 2025 21:55
@brandyscarney brandyscarney requested a review from thetaPC June 23, 2025 21:55
@brandyscarney brandyscarney marked this pull request as draft June 23, 2025 22:24
@brandyscarney brandyscarney marked this pull request as ready for review June 24, 2025 16:07
@brandyscarney brandyscarney requested a review from ShaneK June 24, 2025 16:11
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvement! Also thanks for fixing my typos 🔥

@brandyscarney brandyscarney merged commit f42e39e into next Jun 26, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6572 branch June 26, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants