fix(button): fix colors and ripple-effect #30764
Open
+33
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
requested changes
Oct 30, 2025
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
thetaPC
requested changes
Oct 31, 2025
- clean warning rule; - update solid background-activated var;
- define outline warning color ;
thetaPC
requested changes
Nov 4, 2025
There was a problem hiding this comment.
As I mentioned in this comment, we don't use var() because the tokens are set up to not need var. Please remove them again.
Also checks are failing, please fix them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information
clear
outline
test theme