Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(extras): add dynamic slot name change fix to slot fix list #1337

Merged

Conversation

tanner-reits
Copy link
Member

This adds ionic-team/stencil#2982 to the list of fixes from experimentalSlotFixes

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 3:45pm

@@ -103,6 +103,8 @@ with the intent of making these the default behavior in Stencil v5. When set to
- Slot element loses its parent reference and disappears when its parent is rendered conditionally [(#3913)](https://github.com/ionic-team/stencil/issues/3913) (since v4.8.2)
- Failed to execute 'removeChild' on 'Node' [(#3278)](https://github.com/ionic-team/stencil/issues/3278) (since v4.9.0)
- React fails to manage children in Stencil slot [(#2259)](https://github.com/ionic-team/stencil/issues/2259) (since v4.9.0)
<!-- TODO confirm fix version (propagate if necessary) -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make sure this is accurate before the next release. Just not sure if that'll be a minor or patch release yet

@tanner-reits tanner-reits marked this pull request as ready for review January 29, 2024 19:14
@tanner-reits tanner-reits requested a review from a team as a code owner January 29, 2024 19:14
@tanner-reits tanner-reits requested review from christian-bromann and alicewriteswrongs and removed request for a team January 29, 2024 19:14
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tanner-reits tanner-reits merged commit 77a9964 into main Feb 5, 2024
5 checks passed
@tanner-reits tanner-reits deleted the docs/add-dynamic-slot-name-change-to-extras-fixes branch February 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants