docs(framework-integrations): add note about consuming custom elements #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner-reits
requested review from
christian-bromann and
alicewriteswrongs
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rwaskiewicz
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an admonition to each of the framework wrapper output targets about consuming the output of
dist-custom-elements.Since Stencil v4, we had to introduce
customElementExportBehaviorand the build no-longer automatically has the output ofsingle-export-modulebehavior. Unfortunately, our framework wrappers rely on this behavior when generating the proxies, so devs need to be aware to explicitly set this option.Note: I will propagate this changes to all v4 versions once approved