chore(test): update piercing docs #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
requested review from
rwaskiewicz and
alicewriteswrongs
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
rwaskiewicz
reviewed
Mar 27, 2024
| @@ -85,19 +85,11 @@ Use the "piercing" selector `>>>` to query for an object inside a component's sh | |||
| const el = await page.find('foo-component >>> .close-button'); | |||
| ``` | |||
|
|
|||
| :::caution | |||
| Make sure to only use `>>>` once in your query. Puppeteer does not support nested deep selectors. Instead, separate the calls into two queries, e.g.: | |||
| By default Stencil will look into all shadow roots to find the element. However if you want to restrict your query by specifying the shadow root of a particular component, you can chain multiple deep selectors within the same query, e.g.: | |||
There was a problem hiding this comment.
Will this change only be in affect for Stencil v4.14 and up? If so, shouldn't we leave the other docs as-is?
christian-bromann
force-pushed
the
cb/piercing-note
branch
from
f0284ab to
4da1b08
Compare
|
@rwaskiewicz I removed the changes in older versions of the docs which remain suggesting using Puppeteer primitives. |
rwaskiewicz
approved these changes
Mar 27, 2024
tanner-reits
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I've discovered a limitation with Stencils deep locator and put up a PR to let users know about this limitation. Now, after working on ionic-team/stencil#5481 this limitation was fixed and we can update the docs again.
Summary:
This patch documents that user can use multiple deep selectors in their queries.