Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ot-readme): add internal jsdoc documentation #1384

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Mar 28, 2024

add a section on the behavior of the @internal jsdoc tag

ths impetus for this is an internal slack convo with Liam in the ask-stencil channel

I'll backport it once it's been approved

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 3:26pm

@rwaskiewicz rwaskiewicz marked this pull request as ready for review March 28, 2024 13:05
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner March 28, 2024 13:05
@rwaskiewicz rwaskiewicz requested review from alicewriteswrongs and tanner-reits and removed request for a team March 28, 2024 13:05
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwaskiewicz rwaskiewicz merged commit fd2a45d into main Mar 29, 2024
5 checks passed
@rwaskiewicz rwaskiewicz deleted the rw/internal-flag branch March 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants