Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo dist.md 'Distribution Options' docs #1497

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

johnjenkins
Copy link
Contributor

@johnjenkins johnjenkins commented Dec 2, 2024

Docs regarding 'Distribution Options' in Stencil were (I believe) wrongly removed.

  1. they're useful
  2. they're mentioned in remaining text - "loading the components directly through a script tag as mentioned below"

Docs regarding 'Distribution Options' in Stencil were (I believe) wrongly removed.

1) they're useful
2) they're mentioned in remaining text - "loading the components directly through a script tag as mentioned below" - < they're not there anymore
@johnjenkins johnjenkins requested a review from a team as a code owner December 2, 2024 10:26
@johnjenkins johnjenkins requested review from christian-bromann and gnbm and removed request for a team December 2, 2024 10:26
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:28am

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more docs the merrier 😉

@christian-bromann christian-bromann merged commit c69c7fc into ionic-team:main Dec 3, 2024
5 checks passed
@johnjenkins johnjenkins deleted the patch-1 branch December 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants