Cannot render tables #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can you rebase this one please? |
Aye. Will do this on my commute back home. |
WalternativE
force-pushed
the
cannot-render-tables
branch
from
ca0fa1a
to
cf5d5f2
Compare
Done 👨💻 |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to create this PR in relation to #16 as there has been no activity for a couple of months. Still, all changes where originally implemented by @grishace - I just condensed them a bit and made some adjustments.
I thought that directly referencing the Markdig spec sites would be beneficial as tables aren't part of the CommonMark spec. I also decided to only include the table extensions as I didn't want to just decide willy-nilly if this is a good idea. Should be part of another issue and PR (if not solved by the possibility to supply one's own render function as suggested in the original issue it should be at least configurable).