Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FCS to version 7.0.400 and adjust to API changes #194

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

baronfel
Copy link
Collaborator

@baronfel baronfel commented Aug 21, 2023

WHAT

🤖 Generated by Copilot at 099ee60

This pull request updates the proj-info library and its dependencies to support the latest F# language features and tools. It updates FSharp.Compiler.Service to version 7.0.400 and adapts the library and test code to use the new API for FSharpReferencedProject. It also updates fake-cli and fantomas to their latest versions and fixes a typo in the build script. It documents the changes in the CHANGELOG.md file.

🤖 Generated by Copilot at 099ee60

Sing, O Muse, of the valiant deeds of the proj-info team
Who with skill and wisdom updated their library and tools
To harness the power of FSharp.Compiler.Service, the shining star
That guides the F# language to new heights of beauty and grace

🐛🚀♻️

WHY

HOW

🤖 Generated by Copilot at 099ee60

  • Migrate to FSharp.Compiler.Service version 7.0.400 to support the latest F# language features and fix some bugs (link, link, link, link)
  • Update the way the proj-info library creates and accesses FSharpReferencedProject instances from different sources using the new API (link, link)
  • Simplify and refactor the test code to use pattern matching and named fields on the FSharpReferencedProject type instead of internal helper functions (link, link, link, link, link, link)
  • Update the version of the fake-cli tool to 6.0.0 in the .config/dotnet-tools.json file as part of the migration to FAKE 6 (link)
  • Update the version of the fantomas tool to 6.1.2 in the .config/dotnet-tools.json file as part of the migration to Fantomas 6 (link)
  • Fix a typo in the build/Program.fs file that prevented the CheckFormat target from working correctly (link)
  • Remove a redundant dependency on the MSBuild.StructuredLogger package from the paket.dependencies file (link)

@baronfel
Copy link
Collaborator Author

This should be good to go - I've built the packages locally and here's what the relevant dependencies groups look like:

Ionide.ProjInfo:
image

Ionide.ProjInfo.FCS:
image

These look open-ended enough to not cause the hurdle that we ran into for this version update.

@TheAngryByrd
Copy link
Member

looks right to me!

@baronfel baronfel merged commit 62e15bb into main Aug 21, 2023
10 checks passed
@baronfel baronfel deleted the update-fcs-dependency branch August 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants