This repository has been archived by the owner on Dec 2, 2023. It is now read-only.
fix: rooms not created TTL Expired #604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everywhere we have type declaration and usage for avatar and extraInfo for peer. But not set on redis while creating peers.
Before pinfo null check routines returning error sid and uid are dereferenced. Moved the dereference after error handling for null check.
On UpdatePeer event and AddPeer methods there is missing implementation for updating or adding avatar and extrInfo of a peer.
Peers are able to join on the TTL expired room. But room entry not created on the redis only peers entry is created. Checking the room entry exist on the redis if not creating one. This kind of approach used on old version, removed on the latest releases.
Pion master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user joins the room while the room TTL expires, Redis entry for the room is not created as the checking is happing only on user profile SID insted of checking in redis as like v1.
So added a check from redis for rooms.