Skip to content

Commit

Permalink
added note
Browse files Browse the repository at this point in the history
  • Loading branch information
lubedacht committed Jan 2, 2024
1 parent abe02fc commit 6704b25
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/scope/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ func (c *ClusterScope) patchObject() error {
// It also implements a retry mechanism to increase the chance of success
// in case the patch operation was not successful.
func (c *ClusterScope) Finalize() error {
// NOTE(lubedacht) retry is only a way to reduce the failure chance,
// but in general, the reconciliation logic must be resilient
// to handle an outdated resource from that API server.
shouldRetry := func(error) bool { return true }
return retry.OnError(
retry.DefaultBackoff,
Expand Down

0 comments on commit 6704b25

Please sign in to comment.