Skip to content

Commit

Permalink
remove obsolete TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
lubedacht committed Sep 17, 2024
1 parent efa0a00 commit 6e98464
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions internal/service/cloud/loadbalancer.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (s *Service) ensureNLB(
Name: ptr.To(s.nlbName(lb.LoadBalancer)),
ListenerLan: ptr.To(lb.LoadBalancer.Status.NLBStatus.PublicLANID),
TargetLan: ptr.To(lb.LoadBalancer.Status.NLBStatus.PrivateLANID),
Ips: ptr.To(ips), // TODO resolve IP address
Ips: ptr.To(ips),
})
if err != nil {
return nil, true, err
Expand Down Expand Up @@ -447,8 +447,7 @@ func (s *Service) reconcileLoadBalancerLAN(
lanType string,
) (lan *sdk.Lan, requeue bool, err error) {
log := s.logger.WithName("createLoadBalancerLAN")

log.Info("Creating LAN for NLB", "type", lanType)
log.Info("Reconciling LoadBalancer LAN", "type", lanType)

var (
datacenterID = lb.LoadBalancer.Spec.NLB.DatacenterID
Expand All @@ -466,9 +465,11 @@ func (s *Service) reconcileLoadBalancerLAN(
return nil, true, nil
}

log.V(4).Info("LAN is available", "ID", *lan.GetId(), "type", lanType)
return lan, false, nil
}

log.Info("No LAN found, creating LAN for NLB", "type", lanType)
path, err := s.createLoadBalancerLAN(ctx, lanName, datacenterID, lanType == lanTypePublic)
if err != nil {
return nil, false, fmt.Errorf("could not create incoming LAN: %w", err)
Expand Down

0 comments on commit 6e98464

Please sign in to comment.