-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Ability to use VCPUs #136
Conversation
For the next time, please stick to the style guide when adding additional commits to a PR
|
Ah sorry for that. I see I should not have resolved your comments either. |
I just noticed an issue with the tests. I was confused that there are no updated tests in Would you be so kind to update the tests so we can ensure that the correct values are passed to the CreateServer call? |
I am now testing for VCPU or ENTERPRISE |
Quality Gate passedIssues Measures |
I guess I handled all remarks, please let me know if there is more I should change |
@lubedacht I guess I can merge the PR now? |
What is the purpose of this pull request/Why do we need it?
This allows to use server type VCPU instead of ENTERPRISE.
Issue #, if available:
#129
Description of changes:
Added new type field "Type" (default ENTERPRISE) to IonosCloudMachineSpec and use it in buildServerProperties.