Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to pyproject.toml #283

Merged
merged 5 commits into from
Sep 17, 2024
Merged

switch to pyproject.toml #283

merged 5 commits into from
Sep 17, 2024

Conversation

zeromind
Copy link
Collaborator

@zeromind zeromind commented Sep 9, 2024

Use pyproject.toml instead of setup.py.

  • switch to pyproject.toml for dimclient, ndcli, and dim
  • add separate make target to install dependencies for pytest as non-editable, as editable install via pip requires setup.py in EL8, which we do not need
    • adjust workflow to install non-editable pytest dependencies
  • include dim command from move to pyproject.toml #266 as that seems useful, keeping manage_dim and manage_db commands for compatibility

The good(tm) names on PyPI were already taken, so I had to get creative:

prepare for uploading to PyPI
prepare for uploading to PyPI
work around issue on old pip: `ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /__w/dim/dim/dim`, we do not need editable anyway
include required files; report file is needed by the report command
@miesi-ionos
Copy link
Collaborator

@zeromind zeromind mentioned this pull request Sep 11, 2024
@zeromind
Copy link
Collaborator Author

The documentation links are outdated in our documentation, once we fix them, I can update things on PyPI.

imho, fixing the docs should be a separate PR.

@miesi-ionos miesi-ionos merged commit ced4f83 into master Sep 17, 2024
2 checks passed
@miesi-ionos miesi-ionos deleted the pyproject_toml branch September 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants