Feat/improvement for data sources

.github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Build
+name: Sonarcloud and gofmt
 on:
   push:
     branches:
@@ -11,11 +11,28 @@ jobs:
     name: SonarCloud
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+  gofmt:
+    name: "Run gofmt check"
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Unshallow
+        run: git fetch --prune --unshallow
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
+      - name: Check code is formatted properly
+        uses: Jerome1337/[email protected]
+        with:
+          gofmt-path: '.'
+          gofmt-flags: '-l -d'

.github/workflows/daily-test-run.yml → .github/workflows/compute-test-run.yml

@@ -1,9 +1,9 @@
-#This workflow will run every day, running terraform compute-engine tests
-name: Daily compute-engine test run
+#This workflow will run every two days, running terraform compute-engine tests
+name: Every 2 days compute-engine test run
 on:
   schedule:
-# At 09:00:00am, every day between Monday and Friday, every month
-    - cron: '0 09 * * MON-FRI'
+    # At 09:00:00am, every 2 days between Monday and Friday, every month
+    - cron: '0 09 */2 * MON-FRI'
 
 jobs:
   test:
@@ -14,15 +14,14 @@ jobs:
       TF_LOG: debug
     strategy:
       matrix:
-        go-version: [^1.17]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
       - name: Install Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
-          go-version: ${{ matrix.go-version }}
-      - name: Checkout code
-        uses: actions/checkout@v2
+          go-version-file: 'go.mod'
       - name: Run tests with compute tag
         run: go test ./ionoscloud -v -failfast -timeout 240m -tags compute

.github/workflows/dbaas-test-run.yml

@@ -0,0 +1,27 @@
+#This workflow will run every two days, running terraform dbaas tests
+name: Every 2 days dbaas test run
+on:
+  schedule:
+    # At 09:00:00am, every 2 days between Tuesday and Friday, every month
+    - cron: '0 09 */2 * TUE-FRI'
+
+jobs:
+  test:
+    env:
+      IONOS_USERNAME: ${{ secrets.IONOS_VDC_USER_GO_V6 }}
+      IONOS_PASSWORD: ${{ secrets.IONOS_VDC_PASSWORD_GO_V6 }}
+      TF_ACC: true
+      TF_LOG: debug
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+      - name: Install Go
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
+      - name: Run tests with dbaas tag
+        run: go test ./ionoscloud -v -failfast -timeout 240m -tags dbaas

.github/workflows/k8s-test-run.yml

@@ -0,0 +1,26 @@
+name: Weekly k8s test run
+on:
+  schedule:
+    # At 09:00:00 - UTC, every week on Monday, every month.
+    - cron: '0 09 * * MON'
+
+jobs:
+  test:
+    env:
+      IONOS_USERNAME: ${{ secrets.IONOS_VDC_USER_GO_V6 }}
+      IONOS_PASSWORD: ${{ secrets.IONOS_VDC_PASSWORD_GO_V6 }}
+      TF_ACC: true
+      TF_LOG: debug
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+      - name: Install Go
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
+      - name: Run tests with 'k8s' tag
+        run: go test ./ionoscloud -v -failfast -timeout 240m -tags k8s

.github/workflows/release.yml

@@ -20,15 +20,15 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       -
         name: Unshallow
         run: git fetch --prune --unshallow
       -
         name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version-file: 'go.mod'
       -
         name: Import GPG key
         id: import_gpg
@@ -38,7 +38,7 @@ jobs:
           PASSPHRASE: ${{ secrets.PASSPHRASE }}
       -
         name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v2
+        uses: goreleaser/goreleaser-action@v3
         with:
           version: latest
           args: release --rm-dist

.github/workflows/test.yml

@@ -8,7 +8,7 @@ on:
         type: string
         default: master
       test-tags:
-        description: "test tags, in the form of a list without spaces: 'all,compute,server,firewall,k8s,dbaas,natgateway,nlb,waiting_for_vdc' "
+        description: "test tags, in the form of a list without spaces: 'all,compute,k8s,dbaas,natgateway,nlb, alb, server,firewall, etc.' "
         required: false
         type: string
         default: compute
@@ -26,19 +26,18 @@ jobs:
       TF_LOG: ${{ github.event.inputs.tf-log }}
     strategy:
       matrix:
-        go-version: [^1.17]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     steps:
-      - name: Install Go
-        uses: actions/setup-go@v2
-        with:
-          go-version: ${{ matrix.go-version }}
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref:  ${{ github.event.inputs.branch }}
-      - name: Run tests with tags
+      - name: Install Go
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
+      - name: Run tests for ${{ github.event.inputs.test-tags }}
         if: ${{ github.event.inputs.test-tags != '' }}
         run: go test ./ionoscloud -v -failfast -timeout 240m -tags ${{ github.event.inputs.test-tags }}
       - name: Run tests without tags

CHANGELOG.md

@@ -1,4 +1,121 @@
-## 6.2.3(Upcoming Release)
+## 6.3.4(upcoming release)
+### Feature:
+ - Add update for mongo database resources
+ - Add labels for servers
+ - Add data source for DBaaS Mongo Templates
+ - Update mongo sdk to v1.2.0
+
+### Refactor:
+- Refactor services, add generic `WaitForResourceToBeReady` and `WaitForResourceToBeDeleted` methods
+- Removed hard coded passwords from docs and tests and replaced with dynamically generated passwords
+
+## Fixes
+ - Fix mongo user tests to check for cluster state instead of user state which was removed
+ - defining a separate firewall rule for server should not set firewall_id inside server resource, as it moves the firewall resource inside the server on re-apply
+ - Fixes creating share resource edit and share privileges mix up
+ - `viable_node_pool_versions`  in k8s cluster is no longer optional, is only computed
+ - allow server import with nic and firewallId : `terraform import ionoscloud_server.myserver {datacenter uuid}/{server uuid}/{primary nic id}/{firewall rule id}`
+
+## 6.3.3
+### Feature
+- New Product: **ContainerRegistry**:
+  - `Resources`:
+    - [ionoscloud_container_registry](docs/resources/container_registry.md)
+    - [ionoscloud_container_registry_token](docs/resources/container_registry_token.md)
+  - `Data Sources`:
+    - [ionoscloud_container_registry](docs/data-sources/container_registry.md)
+    - [ionoscloud_container_registry_token](docs/data-sources/container_registry_token.md)
+    - [ionoscloud_container_registry_locations](docs/data-sources/container_registry_locations.md)
+
+⚠️ **Note:** Container Registry is currently in the Early Access (EA) phase. We recommend keeping usage and testing to non-production critical applications.
+Please contact your sales representative or support for more information.
+### Fixes
+- Fixes #326, now removing a s3_buckets block from an ionoscloud_k8s_cluster resource triggers a change in the terraform plan.
+- Fixes user creation bug, now user creation works properly when `group_ids` is specified in the plan.
+
+## 6.3.2
+### Feature
+- New Product: **MongoDB**:
+  - `Resources`:
+    - [ionoscloud_mongo_cluster](docs/resources/dbaas_mongo_cluster.md)
+    - [ionoscloud_mongo_user](docs/resources/dbaas_mongo_user.md)
+  - `Data Sources`:
+    - [ionoscloud_mongo_cluster](docs/data-sources/dbaas_mongo_cluster.md)
+    - [ionoscloud_mongo_user](docs/data-sources/dbaas_mongo_user.md)
+
+⚠️ **Note:** DBaaS - MongoDB is currently in the Early Access (EA) phase. We recommend keeping usage and testing to non-production critical applications.
+Please contact your sales representative or support for more information.
+
+- New Product: **Certificate Manager**:
+  - `Resources`:
+    - [ionoscloud_certificate](docs/resources/certificate.md)
+  - `Data Sources`:
+    - [ionoscloud_certificate](docs/data-sources/certificate.md)
+
+
+### Enhancement:
+- Increase go version to 1.18
+- Update dependencies to latest versions
+- Update Ionos Cloud GO SDK v6.1.3. Release notes here [v6.1.3](https://github.com/ionos-cloud/sdk-go/releases/tag/v6.1.3)
+- Update SDK GO DBaaS Postgres to v1.0.4. Release notes here [v1.0.4](https://github.com/ionos-cloud/sdk-go-dbaas-postgres/releases/tag/v1.0.4)
+- `ssh_key_path` will now allow the keys to be passed directly also. In the future, will be renamed to `ssh_keys`.
+
+### Fixes
+- Reproduces rarely: sometimes the `nic` resource is not found after creation. As a fix we added a retry for 5 minutes to be able to get the NIC. The retry will keep trying if the response 
+is `not found`(404)
+- Fix cube server creation. Some attributes were not populated - name, boot_cdrom, availability_zone
+- Crash on update of k8s version when we have a value without `.`
+
+### Documentation
+- add links to documentation for `cube` and `enterprise` fields
+
+## 6.3.1
+
+### Feature
+- When no argument is provided for user data source, try to get the email from the client configuration
+- Update Ionos Cloud GO SDK v6.1.2. Release notes here [v6.1.2](https://github.com/ionos-cloud/sdk-go/releases/tag/v6.1.2)
+- Refactor server and volume creation code
+- Make maintenance_window computed
+
+
+## 6.3.0
+
+### Feature
+- Adds ionoscloud_servers data source that returns a list of servers based on filters set. The filters do partial matching. See docs [here](docs/data-sources/servers.md)
+- New Product: **Application Load Balancer**:
+  - `Resources`:
+    - [ionoscloud_application_loadbalancer](docs/resources/application_loadbalancer.md)
+    - [ionoscloud_application_loadbalancer_forwarding_rule](docs/resources/application_loadbalancer_forwardingrule.md)
+    - [ionoscloud_target_group](docs/resources/target_group.md)
+  - `Data Sources`:
+    - [ionoscloud_application_loadbalancer](docs/data-sources/application_loadbalancer.md)
+    - [ionoscloud_application_loadbalancer_forwarding_rule](docs/data-sources/application_loadbalancer_forwardingrule.md)
+    - [ionoscloud_target_group](docs/data-sources/target_group.md)
+
+### Dependency-update
+  - updated sdk-go version from [6.0.3](https://github.com/ionos-cloud/sdk-go/releases/tag/v6.0.3) to [v6.1.0](https://github.com/ionos-cloud/sdk-go/releases/tag/v6.1.0)
+
+## 6.2.5
+### Enhancement
+- update sdk-go dependency to v6.0.3. 
+  * enable certificate pinning, by setting IONOS_PINNED_CERT env variable
+- temporarily removed `gateway_ip` and `public` fields for k8s
+- introduced error when trying to set `max_node_count` equal to `min_node_count` in `k8s_node_pool`
+
+### Fixes 
+- fixed crash when trying to disable `autoscaling` on `k8s_node_pool`
+
+## 6.2.4
+### Fixes
+- fixed bug when upgrading from a v6.0.0-beta.X version to a stable one (_number is required_ error)
+- reintroduced error for image data source when finding multiple results with data source
+### Enhancement
+- update sdk-go-dbaas-postgres dependency to v1.0.3
+
+### Documentation
+- updated multiple nics under the same IP Failover example, with a [one_step example](examples/ip_failover/README.md)
+
+## 6.2.3
 
 ### Fixes
 - do not allow empty string AvailabilityZone. Only allow "AUTO", "ZONE_1", "ZONE_2", "ZONE_3"