Feat/Network Security Group #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add nsg rule resource, moved logic from nsg
…g and rule import
# Conflicts: # go.mod # ionoscloud/data_source_cube_server.go # ionoscloud/data_source_nic.go # ionoscloud/data_source_server.go # ionoscloud/provider.go # ionoscloud/resource_cube_server.go # ionoscloud/resource_nic.go # ionoscloud/resource_nic_test.go # ionoscloud/resource_server_test.go # services/cloudapi/cloudapinic/nic.go # utils/constant/constants.go
cbeti-ionos
commented
Nov 7, 2024
cbeti-ionos
commented
Nov 7, 2024
Co-authored-by: Ionut Beti <[email protected]>
Co-authored-by: Ionut Beti <[email protected]>
cristiGuranIonos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
cristiGuranIonos,
avirtopeanu-ionos,
adeatcu-ionos,
glimberea and
digna-ionos
and removed request for
a team
adeatcu-ionos
requested changes
Nov 8, 2024
| - [ionoscloud_nsg](docs/resources/nsg.md) | ||
| - [ionoscloud_nsg_firewallrule](docs/resources/nsg_firewallrule.md) | ||
| - `Data Sources`: | ||
| - [ionoscloud_nsg](docs/data-sources/nsg.md) |
There was a problem hiding this comment.
@cristiGuranIonos shouldn't we also have a DS for NSG Firewall Rule?. I see that we can retrieve a NSG using the DS and look into the firewall rules for that NSG, but maybe we also want to retrieve a specific firewall rule using the DC ID and the NSG ID.
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
…plement-nsg # Conflicts: # docs/resources/nsg_firewallrule.md # ionoscloud/resource_nsg.go
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Implements Terraform resources for Network Security Groups and Network Security Group Rules
Checklist
feat:/fix:/doc:/test:/refactor:)