add basic tests for file download

ioos · Jan 16, 2024 · 8e1868e · 8e1868e
1 parent 1b2cab9
commit 8e1868e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/erddapy/erddapy.py b/erddapy/erddapy.py
@@ -488,3 +488,4 @@ def download_file(
         file_name = Path(f"{self.dataset_id}_{constraints_hash}.{file_type}")
         if not file_name.exists():
             urlretrieve(url, file_name)
+        return file_name
diff --git a/tests/test_to_objects.py b/tests/test_to_objects.py
@@ -197,3 +197,16 @@ def test_to_iris_griddap(dataset_griddap):
     """Test converting griddap to an iris cube."""
     cubes = dataset_griddap.to_iris()
     assert isinstance(cubes, iris.cube.CubeList)
+
+
+@pytest.mark.web
+def test_download_file(dataset_tabledap):
+    """Test direct download of tabledap dataset"""
+    fn = dataset_tabledap.download_file("nc")
+    ds = xr.load_dataset(fn)
+    assert ds["time"].name == "time"
+    assert ds["temperature"].name == "temperature"
+    dataset_tabledap.variables = dataset_tabledap.variables[::-1]
+    fn_new = dataset_tabledap.download_file("nc")
+    assert fn_new == fn
+