Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.10 and up #329

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Support Python 3.10 and up #329

merged 5 commits into from
Feb 27, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jan 10, 2024

Python 3.10 EOL is only in 2026-10 but this will allow us to move faster, drop some code, and avoid some deprecation warnings. I'm not in a hurry to merge this but #328 should only be merged after this one.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 26, 2024

@callumrollo and @abkfenris what do you think about this one? On one hand we will be able to move faster and adopt modern practices. However, this may be too premature b/c both 3.9 and 3.10 are still supported. What do you think?

@ocefpaf ocefpaf marked this pull request as draft February 26, 2024 16:24
@callumrollo
Copy link
Contributor

I think it's reasonable to drop earlier python versions at this point. We have mature fully featured releases of erddapy that are compatible with older python versions if users still need to run <3.11

@ocefpaf ocefpaf marked this pull request as ready for review February 26, 2024 17:30
@abkfenris
Copy link
Contributor

I guess my concern is if an ERDDAP release breaks erddapy, are we going to backport the changes, or ask that everyone move to 3.11 to get the fixes?

I know some of my other dependencies just added 3.11 support, and I'm pretty sure there are others that are lagging behind and keeping folks environments delayed with them.

@abkfenris
Copy link
Contributor

And now I'm a little horrified by seeing that 3.8 and 2.7 release cycles overlapped.

How about we follow SPEC 0 and make the minimum version 3.10 to keep pace with the rest of the scientific ecosystem? I think that allows most of the typing updates in this PR.

pyproject.toml Outdated Show resolved Hide resolved
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 27, 2024

I guess my concern is if an ERDDAP release breaks erddapy, are we going to backport the changes, or ask that everyone move to 3.11 to get the fixes?

That is a good point and then my attempt to reduce the load will actually increase it. However, is a remote possibility and, if it happens, we can backport fixes.

And now I'm a little horrified by seeing that 3.8 and 2.7 release cycles overlapped.

😄

How about we follow SPEC 0 and make the minimum version 3.10 to keep pace with the rest of the scientific ecosystem? I think that allows most of the typing updates in this PR.

Let me see if this PR passes on 3.10. If not, I'll make it a draft and wait a bit more.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 27, 2024

OK. It is passing. I'll renamed the PR and check if I got all the py311 -> py310.

@ocefpaf ocefpaf changed the title Support Python 3.11 and up Support Python 3.10 and up Feb 27, 2024
@ocefpaf ocefpaf merged commit 219d8fb into ioos:main Feb 27, 2024
13 checks passed
@ocefpaf ocefpaf deleted the py311 branch February 27, 2024 14:57
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 27, 2024

Thanks @callumrollo and @abkfenris for the huge help here. The may be simple but the implications behind it aren't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants