Fixing ax in plot_ctd and creating new baseline image

ioos · Jul 29, 2024 · 5240abb · 5240abb
1 parent 9232e5c
commit 5240abb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/gliderpy/plotting.py b/gliderpy/plotting.py
@@ -122,11 +122,17 @@ def plot_ctd(
         return fig, ax1
 
     fig = ax.get_figure()
-    ax2 = ax.twiny()  # Create a new twinned axis
+
+    # Check if the ax is already a twinx or twiny
+    if hasattr(ax, "twinned_axis"):
+        ax2 = ax.twinned_axis
+    else:
+        ax2 = ax.twiny()
+        ax.twinned_axis = ax2  # Keep a reference to the twinned axis
+
     ax2.plot(profile[var], profile["pressure"], label=var, color=color)
     ax2.set_xlabel(var)
 
-    # Handle legends
     lines, labels = ax.get_legend_handles_labels()
     lines2, labels2 = ax2.get_legend_handles_labels()
     ax.legend(lines + lines2, labels + labels2, loc="lower center")

diff --git a/tests/baseline/test_plot_ctd.png b/tests/baseline/test_plot_ctd.png
diff --git a/tests/test_plotting.py b/tests/test_plotting.py
@@ -78,5 +78,5 @@ def test_plot_transect_size(glider_data):
 @pytest.mark.mpl_image_compare(baseline_dir=root.joinpath("baseline/"))
 def test_plot_ctd(glider_data):
     """Test plot_ctd accessor."""
-    fig, ax = plot_ctd(glider_data, 0, var="temperature")
+    fig, ax = plot_ctd(glider_data, 0, var="temperature", color="blue")
     return fig