Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ax kwargs to the plotting functions #114

Merged
merged 14 commits into from
Jun 25, 2024

Conversation

FloraSauerbronn
Copy link
Contributor

Update plotting.py, test_plotting and add new figures to tests/baseline/

@ocefpaf
Copy link
Member

ocefpaf commented Jun 21, 2024

If you click on the links for the CIs above you can inspect the log and see the reason for the failures. In this case it is:

==================================== ERRORS ====================================
___________________ ERROR collecting tests/test_plotting.py ____________________
tests/test_plotting.py:14: in <module>
    @pytest.fixture
E   NameError: name 'pytest' is not defined

That means you need to import pytest in the tests/test_plotting.py module.

@FloraSauerbronn
Copy link
Contributor Author

I can't figure out why the image tests are failing. On my local computer, the tests pass, even when I change parameters and they should fail. It seems that, for some reason, pytest is not functioning correctly in my local repository.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 24, 2024

Let me know when you are done writing the tests, I just answered you colobar question on slack, and I'll check what is going on with the figures. I suspect has something to do with your matplotlib installation, fonts, etc. I'll re-generate the figures on my machine before merging.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 25, 2024

@FloraSauerbronn the error is probably due to different fonts in the matplotlib version you have vs the one in the CI system. See the image diff below:

result-failed-diff

We could adjust the tolerance but for now it is easier to just regenerate them in a system that has the same fonts.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 25, 2024

@FloraSauerbronn I updated the images and fixed a few lints. Mostly missing docstrings.

@ocefpaf ocefpaf merged commit 0eff218 into ioos:main Jun 25, 2024
12 checks passed
@ocefpaf ocefpaf mentioned this pull request Jun 25, 2024
@ocefpaf ocefpaf changed the title Update plotting2 Add ax kwargs to the plotting functions Jun 25, 2024
@FloraSauerbronn FloraSauerbronn deleted the update-plotting2 branch August 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants