-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ax kwargs to the plotting functions #114
Conversation
If you click on the links for the CIs above you can inspect the log and see the reason for the failures. In this case it is:
That means you need to |
I can't figure out why the image tests are failing. On my local computer, the tests pass, even when I change parameters and they should fail. It seems that, for some reason, pytest is not functioning correctly in my local repository. |
Let me know when you are done writing the tests, I just answered you colobar question on slack, and I'll check what is going on with the figures. I suspect has something to do with your matplotlib installation, fonts, etc. I'll re-generate the figures on my machine before merging. |
@FloraSauerbronn the error is probably due to different fonts in the matplotlib version you have vs the one in the CI system. See the image diff below: We could adjust the tolerance but for now it is easier to just regenerate them in a system that has the same fonts. |
b937add
to
c5e7829
Compare
@FloraSauerbronn I updated the images and fixed a few lints. Mostly missing docstrings. |
Update plotting.py, test_plotting and add new figures to tests/baseline/