Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New notebook #122

Merged
merged 12 commits into from
Aug 7, 2024
Merged

New notebook #122

merged 12 commits into from
Aug 7, 2024

Conversation

FloraSauerbronn
Copy link
Contributor

New documentation reffering to plotting.py.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 7, 2024

@FloraSauerbronn please let me know when this one is ready for review. Don't worry about the CIs failures for now, focus on the doc text and examples only.

@FloraSauerbronn
Copy link
Contributor Author

@ocefpaf is ready. I've already shown it to Calumn a couple of weeks ago to see if the text fit the documentation. Yesterday, I just corrected the example of the new axis in the CTD plot.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 7, 2024

pre-commit.ci autofix

@ocefpaf ocefpaf merged commit 3963902 into ioos:main Aug 7, 2024
12 checks passed
@FloraSauerbronn
Copy link
Contributor Author

@ocefpaf
Actually something went wrong. The notebook that was merged was not the one that I've recently updated.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 8, 2024

@ocefpaf Actually something went wrong. The notebook that was merged was not the one that I've recently updated.

It has some edits but it is based on your work. The text was too heavy on descriptions and did not made use of the dataframe methods (the whole reason we added pandas_flavor) vs imported functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants