Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #81

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 1, 2024

Closes #35

@ocefpaf ocefpaf force-pushed the increase_test_coverage branch 3 times, most recently from 07096e5 to da14c26 Compare June 12, 2024 15:42
@ocefpaf ocefpaf marked this pull request as ready for review June 27, 2024 07:18
@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 27, 2024

@FloraSauerbronn, as a change of pace and in order to give you a different experience in GSoC. I would like you to review this PR. The review process usually consists of:

  1. Check if the tests are passing;
  2. Check if the context of the new code is aligned with the PR title and commit messages;
  3. Try to understand the code changes, see if they make sense, and try to spot any places for improvements or errors.

You may find that step 3 can be quite demanding but please ask questions, in the PR using the code comment feature of GitHub, to ask for clarifications.

FloraSauerbronn
FloraSauerbronn approved these changes Jul 1, 2024
@ocefpaf ocefpaf merged commit def8d7d into ioos:main Jul 4, 2024
12 checks passed
@ocefpaf ocefpaf deleted the increase_test_coverage branch July 4, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test request to server
2 participants