Fix: Checkout to the correct repo #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change the realsense library to ROS1 version 2. Change the server key
scheunemann
reviewed
Feb 20, 2023
Comment on lines
+31
to
+34
| git clone https://github.com/IntelRealSense/realsense-ros.git && \ | ||
| cd realsense-ros && \ | ||
| git checkout ros1-legacy && \ | ||
| cd .. && \ |
There was a problem hiding this comment.
Your changes work for me, thank you. You could streamline the command a little like this:
Suggested change
| git clone https://github.com/IntelRealSense/realsense-ros.git && \ | |
| cd realsense-ros && \ | |
| git checkout ros1-legacy && \ | |
| cd .. && \ | |
| git clone --branch ros1-legacy https://github.com/IntelRealSense/realsense-ros.git && \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dockerfile you created is great, however, the realsense-ros repo has changed the default to ros2, so I think the dockerfile should be changed.
Let me know if I misunderstand anything!