Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer to xcodebuild to validate simulator versions #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerrymarino
Copy link
Collaborator

Currently the code attempts to validate runtimes, which can get thrown
off in a few scenarios.

By deferring to xcodebuild / Apple to validate options, it's easier to
maintain the xctestrunner

Fixes: google#12

Currently the code attempts to validate runtimes, which can get thrown
off in a few scenarios.

By deferring to `xcodebuild` / Apple to validate options, it's easier to
maintain the xctestrunner

Fixes: google#12
@@ -582,34 +580,6 @@ def _ValidateSimulatorType(device_type):
'device types are %s.' % (device_type, supported_sim_device_types))


def _ValidateSimulatorTypeWithOsVersion(device_type, os_version):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple tooling should determine if the passed simulator and runtime is valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 11.3 validation issues
1 participant